Metal backend: add export-time code signing for Hardened Runtime#18768
Draft
mergennachin wants to merge 1 commit intomainfrom
Draft
Metal backend: add export-time code signing for Hardened Runtime#18768mergennachin wants to merge 1 commit intomainfrom
mergennachin wants to merge 1 commit intomainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
mergennachin
force-pushed
the
turboquant
branch
2 times, most recently
from
f86121f to
fa44add
Compare
The Metal AOTI backend extracts a compiled .so from the .pte at runtime and dlopen's it. macOS Hardened Runtime rejects unsigned dlopen'd code, making Metal-backend .pte files unusable in notarized apps. Add a `codesign_so` hook to `AotiBackend` (no-op by default) that runs after AOTInductor compilation and before the .so is packed into the .pte. `MetalBackend` overrides it to run `codesign` when a `codesign_identity` compile spec is provided. Wire `--codesign-identity` through the Voxtral Realtime and Parakeet export scripts. Add an e2e test in test_modules that exports a toy model with ad-hoc signing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Metal AOTI backend extracts a compiled .so from the .pte at runtime
and dlopen's it. macOS Hardened Runtime rejects unsigned dlopen'd code,
making Metal-backend .pte files unusable in notarized apps.
Add a
codesign_sohook toAotiBackend(no-op by default) that runsafter AOTInductor compilation and before the .so is packed into the .pte.
MetalBackendoverrides it to runcodesignwhen acodesign_identitycompile spec is provided. Wire
--codesign-identitythrough the VoxtralRealtime and Parakeet export scripts.